DELIVERY-212 UI tweaks to pick-source popup and create instance modal.#2
Open
marcioesparzaGL wants to merge 2 commits intomasterfrom
Open
DELIVERY-212 UI tweaks to pick-source popup and create instance modal.#2marcioesparzaGL wants to merge 2 commits intomasterfrom
marcioesparzaGL wants to merge 2 commits intomasterfrom
Conversation
Warp text and fix close icon in create instance modal.
Contributor
|
It looks very good. One thing I was wondering about is if you could add some padding to the sides? This screenshot is of your change:
and this screenshot is of the original code:
Note that the old code would wrap to 3 lines in order to provide some padding on the sides. It definitely looks better overall than it did so if you can't fix this that's fine. I just thought I'd check. |
Author
|
@rrothenb I have added padding to sides, attaching screenshots in small and medium resolution:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add padding to pick-source popup. Attaching different resolutions
Wrap text and fix close icon position in create-instance modal